Improve SessionPoolExample by replacing unbounded fixed thread pool w…#17269
Open
anusha975 wants to merge 1 commit intoapache:masterfrom
Open
Improve SessionPoolExample by replacing unbounded fixed thread pool w…#17269anusha975 wants to merge 1 commit intoapache:masterfrom
anusha975 wants to merge 1 commit intoapache:masterfrom
Conversation
…ith bounded ThreadPoolExecutor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the SessionPoolExample by replacing the use of Executors.newFixedThreadPool() with a ThreadPoolExecutor backed by a bounded queue.
Motivation:
Executors.newFixedThreadPool internally uses an unbounded LinkedBlockingQueue, which may allow unlimited task accumulation and potentially lead to OutOfMemoryError in high-throughput scenarios.
Since this is an official example, using a bounded queue demonstrates safer best practices for users.
Changes:
This change only affects example code and does not modify core IoTDB functionality.